Skip to content

chore: v1 implementation of admin and assembly condition stubs #2391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 21, 2025
Merged

chore: v1 implementation of admin and assembly condition stubs #2391

merged 10 commits into from
Nov 21, 2025

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Nov 20, 2025

Description

As title says

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Nov 20, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 20, 2025 16:10
@codecov
Copy link

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.74627% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.98%. Comparing base (454f13e) to head (636bb90).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 20.83% 19 Missing ⚠️
...etry/core/_grpc/_services/v1/assembly_condition.py 48.14% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2391      +/-   ##
==========================================
- Coverage   95.21%   94.98%   -0.24%     
==========================================
  Files         168      169       +1     
  Lines       11290    11327      +37     
==========================================
+ Hits        10750    10759       +9     
- Misses        540      568      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment but LGTM!

RobPasMue
RobPasMue previously approved these changes Nov 20, 2025
View reviewed changes
@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) November 20, 2025 16:40
@RobPasMue RobPasMue disabled auto-merge November 21, 2025 10:48
@RobPasMue RobPasMue merged commit 61bffdd into main Nov 21, 2025
49 of 51 checks passed
@RobPasMue RobPasMue deleted the chore/v1_admin_assembly_condition_impl branch November 21, 2025 10:48
@jacobrkerstetter jacobrkerstetter mentioned this pull request Nov 21, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacobrkerstetter @RobPasMue @pyansys-ci-bot